Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install support #618

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make install support #618

wants to merge 2 commits into from

Conversation

Teklad
Copy link

@Teklad Teklad commented Nov 17, 2019

Adds better support for "make install". ResourceManager now does lookups in standard share directories and cmake properly adds the "resources" directory to its install targets.

Justin Kinnaird added 2 commits November 17, 2019 12:08
For Linux, this includes the following directories:
* <HOME>/.local/share/<APPNAME>
* /usr/local/share/<APPNAME>
* /usr/share/<APPNAME>
@joolswills
Copy link
Member

Thanks. Short on time but will check / review soon.

@gllmhyt
Copy link

gllmhyt commented May 21, 2020

Hello, thank you for this patch. But even with this, I'm still getting an error with my build directory used to search resources for fonts apparently:

May 21 10:06:21 lvl0: 	Error - File type unknown!
emulationstation: /home/postblue/Documents/Projets/PKGBUILDs/emulationstation/src/EmulationStation-2.9.1/es-core/src/resources/Font.cpp:21: Font::FontFace::FontFace(ResourceData&&, int): Assertion `!err' failed.
[1]    90162 abort (core dumped)  emulationstation

I'm trying to make a working PKGBUILD here. When built, the packager complains about references to source directory for the files usr/lib/libpugixml.a and usr/bin/emulationstation. Can you please have a look at it?

@gllmhyt
Copy link

gllmhyt commented Sep 10, 2020

Follow up: this patch enables easier packaging solutions using make install, creating /usr/share/EmulationStation but I end up with resources in /usr/share/EmulationStation/resources/resources and not /usr/share/EmulationStation/resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants